netdev - Re: ethtool option to force interpretation of diagnostics?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200110131358.GA19739@lunn.ch>
Date:   Fri, 10 Jan 2020 14:13:58 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Preimesberger <ccpisme@...il.com>
Cc:     linville@...driver.com, netdev@...r.kernel.org
Subject: Re: ethtool option to force interpretation of diagnostics?

On Thu, Jan 09, 2020 at 06:25:07PM -0600, Chris Preimesberger wrote:
> Hello,
> 
> 
> Problem:
> I am testing some 10GbE RJ45 SFP+ modules and noticed that they
> accurately report their operating temperature while installed in a
> switch, but not while installed in a NIC that's being probed by
> ethtool.  The ethtool install and NIC port in question are known to
> properly report all diagnostics of installed fiber transceivers, so I
> suspect that maybe my copper transceiver's diagnostics are being
> ignored by ethtool because the diagnostic data from them is considered
> incomplete, due to the transceiver not reporting any valid Laser
> related diagnostics (because they have no laser); this is just a guess
> as to why, and I don't know whether that's the case; I'd appreciate it
> if anyone could confirm whether that's the case.
> 
> Question:
> Is there currently a way to, or can an option be made to force ethtool
> to read and interpret the transceiver's diagnostic data for cases like
> mine, where diagnostic data exists, but is not displayed by default?
> 
> 
> In case it helps, here is an example ethtool output from a transceiver
> that accurately reports temp while installed in a switch, but not
> while in a NIC and being probed by ethtool (some values masked with
> xxxxxxxx for privacy):

Hi Chris

Have you single stepped through ethtool to see why it does not display
temperatures?

What i notice is that

Optical diagnostics support               : Yes

is not present in the output. That suggests the EEPROM contents says
there is no diagnostics available, and hence ethtool is skipping all
the diagnostic information in the EEPROM contents.

A few suggestions:

Check SFP SMA. Is there a bit somewhere which indicates temperature is
supported, even if optical diagnostics are not? We can then add
support for this to ethtool.

Check if the SFP manufacture has a data sheet indicating its
behaviour. Does it clearly document that diagnostics are not
available, but nether the less, temperature values are valid? If so,
we could consider adding a quirk to ethtool to look for this SFP and
dump temperature information.

     Andrew