[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1d00deb9-16fc-b2a5-f8f7-5bb8316dbac2@intel.com>
Date: Fri, 10 Jan 2020 09:52:18 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Yunsheng Lin <linyunsheng@...wei.com>, netdev@...r.kernel.org
Cc: valex@...lanox.com, jiri@...nulli.us
Subject: Re: [PATCH v2 0/3] devlink region trigger support
On 1/9/2020 8:10 PM, Yunsheng Lin wrote:
> On 2020/1/10 3:33, Jacob Keller wrote:
>> This series consists of patches to enable devlink to request a snapshot via
>> a new DEVLINK_CMD_REGION_TRIGGER_SNAPSHOT.
>>
>> A reviewer might notice that the devlink health API already has such support
>> for handling a similar case. However, the health API does not make sense in
>> cases where the data is not related to an error condition.
>
> Maybe we need to specify the usecases for the region trigger as suggested by
> Jacob.
>
> For example, the orginal usecase is to expose some set of flash/NVM contents.
> But can it be used to dump the register of the bar space? or some binary
> table in the hardware to debug some error that is not detected by hw?
>
regions can essentially be used to dump arbitrary addressable content. I
think all of the above are great examples.
I have a series of patches to update and convert the devlink
documentation, and I do provide some further detail in the new
devlink-region.rst file.
Perhaps you could review that and provide suggestions on what would make
sense to add there?
https://lore.kernel.org/netdev/20200109224625.1470433-13-jacob.e.keller@intel.com/
Thanks,
Jake
Powered by blists - more mailing lists