netdev - Re: [PATCH net] net/tls: fix async operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200110.112206.136037463219370475.davem@davemloft.net>
Date:   Fri, 10 Jan 2020 11:22:06 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        borisp@...lanox.com, aviadye@...lanox.com,
        john.fastabend@...il.com, daniel@...earbox.net,
        mallesham.jatharakonda@...convergence.com,
        simon.horman@...ronome.com
Subject: Re: [PATCH net] net/tls: fix async operation

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri, 10 Jan 2020 04:38:32 -0800

> Mallesham reports the TLS with async accelerator was broken by
> commit d10523d0b3d7 ("net/tls: free the record on encryption error")
> because encryption can return -EINPROGRESS in such setups, which
> should not be treated as an error.
> 
> The error is also present in the BPF path (likely copied from there).
> 
> Reported-by: Mallesham Jatharakonda <mallesham.jatharakonda@...convergence.com>
> Fixes: d3b18ad31f93 ("tls: add bpf support to sk_msg handling")
> Fixes: d10523d0b3d7 ("net/tls: free the record on encryption error")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>

Applied and queued up for -stable, thanks.