netdev - [bpf PATCH v2 0/8] Fixes for sockmap/tls from more complex BPF progs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200111061206.8028-1-john.fastabend@gmail.com>
Date:   Sat, 11 Jan 2020 06:11:58 +0000
From:   John Fastabend <john.fastabend@...il.com>
To:     bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, daniel@...earbox.net, ast@...nel.org,
        john.fastabend@...il.com, song@...nel.org, jonathan.lemon@...il.com
Subject: [bpf PATCH v2 0/8] Fixes for sockmap/tls from more complex BPF progs

To date our usage of sockmap/tls has been fairly simple, the BPF programs
did only well-defined pop, push, pull and apply/cork operations.

Now that we started to push more complex programs into sockmap we uncovered
a series of issues addressed here. Further OpenSSL3.0 version should be
released soon with kTLS support so its important to get any remaining
issues on BPF and kTLS support resolved.

Additionally, I have a patch under development to allow sockmap to be
enabled/disabled at runtime for Cilium endpoints. This allows us to stress
the map insert/delete with kTLS more than previously where Cilium only
added the socket to the map when it entered ESTABLISHED state and never
touched it from the control path side again relying on the sockets own
close() hook to remove it.

To test I have a set of test cases in test_sockmap.c that expose these
issues. Once we get fixes here merged and in bpf-next I'll submit the
tests to bpf-next tree to ensure we don't regress again. Also I've run
these patches in the Cilium CI with OpenSSL (master branch) this will
run tools such as netperf, ab, wrk2, curl, etc. to get a broad set of
testing.

I'm aware of two more issues that we are working to resolve in another
couple (probably two) patches. First we see an auth tag corruption in
kTLS when sending small 1byte chunks under stress. I've not pinned this
down yet. But, guessing because its under 1B stress tests it must be
some error path being triggered. And second we need to ensure BPF RX
programs are not skipped when kTLS ULP is loaded. This breaks some of
the sockmap selftests when running with kTLS. I'll send a follow up
for this.

v2: I dropped a patch that added !0 size check in tls_push_record
    this originated from a panic I caught awhile ago with a trace
    in the crypto stack. But I can not reproduce it anymore so will
    dig into that and send another patch later if needed. Anyways
    after a bit of thought it would be nicer if tls/crypto/bpf didn't
    require special case handling for the !0 size.

John Fastabend (8):
  bpf: sockmap/tls, during free we may call tcp_bpf_unhash() in loop
  bpf: sockmap, ensure sock lock held during tear down
  bpf: sockmap/tls, push write_space updates through ulp updates
  bpf: sockmap, skmsg helper overestimates push, pull, and pop bounds
  bpf: sockmap/tls, msg_push_data may leave end mark in place
  bpf: sockmap/tls, tls_sw can create a plaintext buf > encrypt buf
  bpf: sockmap/tls, skmsg can have wrapped skmsg that needs extra
    chaining
  bpf: sockmap/tls, fix pop data with SK_DROP return code

 include/linux/skmsg.h | 13 +++++++++----
 include/net/tcp.h     |  6 ++++--
 net/core/filter.c     | 11 ++++++-----
 net/core/skmsg.c      |  2 ++
 net/core/sock_map.c   |  7 ++++++-
 net/ipv4/tcp_bpf.c    |  5 +----
 net/ipv4/tcp_ulp.c    |  6 ++++--
 net/tls/tls_main.c    | 10 +++++++---
 net/tls/tls_sw.c      | 31 +++++++++++++++++++++++++++----
 9 files changed, 66 insertions(+), 25 deletions(-)

-- 
2.17.1