netdev - Re: [PATCH bpf] bpftool: Fix printing incorrect pointer in btf_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e5a0dfc-6b22-4a5f-d305-da920c9a44c7@netronome.com>
Date:   Sat, 11 Jan 2020 20:07:52 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Martin KaFai Lau <kafai@...com>, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>, kernel-team@...com,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf] bpftool: Fix printing incorrect pointer in
 btf_dump_ptr

2020-01-10 15:16 UTC-0800 ~ Martin KaFai Lau <kafai@...com>
> For plain text output, it incorrectly prints the pointer value
> "void *data".  The "void *data" is actually pointing to memory that
> contains a bpf-map's value.  The intention is to print the content of
> the bpf-map's value instead of printing the pointer pointing to the
> bpf-map's value.
> 
> In this case, a member of the bpf-map's value is a pointer type.
> Thus, it should print the "*(void **)data".
> 
> Fixes: 22c349e8db89 ("tools: bpftool: fix format strings and arguments for jsonw_printf()")
> Cc: Quentin Monnet <quentin.monnet@...ronome.com>
> Signed-off-by: Martin KaFai Lau <kafai@...com>

My bad, thank you for the fix!

Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>