netdev - RE: [PATCH bpf-next v2 01/11] bpf, sk_msg: Don't reset saved sock proto on restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e1a5138b2ba5_1e7f2b0c859c45c05a@john-XPS-13-9370.notmuch>
Date:   Sat, 11 Jan 2020 14:50:32 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>, bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, kernel-team@...udflare.com,
        Eric Dumazet <edumazet@...gle.com>,
        John Fastabend <john.fastabend@...il.com>,
        Lorenz Bauer <lmb@...udflare.com>,
        Martin KaFai Lau <kafai@...com>
Subject: RE: [PATCH bpf-next v2 01/11] bpf, sk_msg: Don't reset saved sock
 proto on restore

Jakub Sitnicki wrote:
> There is no need to reset psock->sk_proto when restoring socket protocol
> callbacks (sk->sk_prot). The psock is about to get detached from the sock
> and eventually destroyed.
> 
> No harm done if we restore the protocol callbacks twice, while it makes
> reasoning about psock state easier, that is once psock was initialized, we
> can assume psock->sk_proto is set.
> 
> Also, we don't need a fallback for when socket is not using ULP.
> tcp_update_ulp already does this for us.
> 
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> ---

Acked-by: John Fastabend <john.fastabend@...il.com>