netdev - Re: [PATCH v2 net] net: macb: fix for fixed-link mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200111.153348.1795240699245945693.davem@davemloft.net>
Date:   Sat, 11 Jan 2020 15:33:48 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     mparab@...ence.com
Cc:     nicolas.ferre@...rochip.com, jakub.kicinski@...ronome.com,
        andrew@...n.ch, antoine.tenart@...tlin.com,
        rmk+kernel@...linux.org.uk, Claudiu.Beznea@...rochip.com,
        f.fainelli@...il.com, netdev@...r.kernel.org, hkallweit1@...il.com,
        linux-kernel@...r.kernel.org, dkangude@...ence.com,
        a.fatoum@...gutronix.de, brad.mouring@...com, pthombar@...ence.com
Subject: Re: [PATCH v2 net] net: macb: fix for fixed-link mode

From: Milind Parab <mparab@...ence.com>
Date: Fri, 10 Jan 2020 13:25:27 +0000

>  static int macb_phylink_connect(struct macb *bp)
>  {
>  	struct net_device *dev = bp->dev;
>  	struct phy_device *phydev;
> +	struct device_node *dn = bp->pdev->dev.of_node;
>  	int ret;

Please retain the reverse christmas tree ordering of local variables
here.

Thank you.