netdev - Re: [PATCH net-next] ptr_ring: add include of linux/mm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200113081641-mutt-send-email-mst@kernel.org>
Date:   Mon, 13 Jan 2020 08:16:50 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jason Wang <jasowang@...hat.com>
Subject: Re: [PATCH net-next] ptr_ring: add include of linux/mm.h

On Mon, Jan 13, 2020 at 11:22:16AM +0100, Jesper Dangaard Brouer wrote:
> Commit 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
> started to use kvmalloc_array and kvfree, which are defined in mm.h,
> the previous functions kcalloc and kfree, which are defined in slab.h.
> 
> Add the missing include of linux/mm.h.  This went unnoticed as other
> include files happened to include mm.h.
> 
> Fixes: 0bf7800f1799 ("ptr_ring: try vmalloc() when kmalloc() fails")
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

Acked-by: Michael S. Tsirkin <mst@...hat.com>

> ---
>  include/linux/ptr_ring.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
> index 0abe9a4fc842..417db0a79a62 100644
> --- a/include/linux/ptr_ring.h
> +++ b/include/linux/ptr_ring.h
> @@ -23,6 +23,7 @@
>  #include <linux/types.h>
>  #include <linux/compiler.h>
>  #include <linux/slab.h>
> +#include <linux/mm.h>
>  #include <asm/errno.h>
>  #endif
>  
>