netdev - Re: [PATCH net-next v5 06/15] net: macsec: add nla support for changing the offloading selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Jan 2020 16:20:48 +0100
From:   Antoine Tenart <antoine.tenart@...tlin.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Antoine Tenart <antoine.tenart@...tlin.com>, davem@...emloft.net,
        sd@...asysnail.net, andrew@...n.ch, f.fainelli@...il.com,
        hkallweit1@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
        alexandre.belloni@...tlin.com, allan.nielsen@...rochip.com,
        camelia.groza@....com, Simon.Edelhaus@...antia.com,
        Igor.Russkikh@...antia.com, jakub.kicinski@...ronome.com
Subject: Re: [PATCH net-next v5 06/15] net: macsec: add nla support for
 changing the offloading selection

Hello Jiri,

On Mon, Jan 13, 2020 at 04:02:02PM +0100, Jiri Pirko wrote:
> 
> I wonder, did you consider having MACSEC_OFFLOAD_ATTR_TYPE attribute
> passed during the macsec device creation (to macsec_newlink), so the
> device is either created "offloded" or not? Looks like an extra step.
> Or do you see a scenario one would change "offload" setting on fly?
> If not, I don't see any benefit in having this as a separate command.

That would be possible as well. When we discussed offloading selection
we thought allowing the user to fallback to another offloading mode when
a rule or a set of rules isn't supported by a given device would be
useful, even though updating the offloading selection at runtime isn't
fully transparent for now (this would be a nice follow-up).

Thanks,
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com