lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jan 2020 17:01:11 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Antoine Tenart <antoine.tenart@...tlin.com> Cc: davem@...emloft.net, sd@...asysnail.net, andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com, allan.nielsen@...rochip.com, camelia.groza@....com, Simon.Edelhaus@...antia.com, Igor.Russkikh@...antia.com, jakub.kicinski@...ronome.com Subject: Re: [PATCH net-next v5 02/15] net: macsec: introduce the macsec_context structure Mon, Jan 13, 2020 at 04:12:31PM CET, antoine.tenart@...tlin.com wrote: >On Mon, Jan 13, 2020 at 03:39:56PM +0100, Jiri Pirko wrote: >> Fri, Jan 10, 2020 at 05:19:57PM CET, antoine.tenart@...tlin.com wrote: >> >> >diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h >> >index 1d69f637c5d6..024af2d1d0af 100644 >> >--- a/include/uapi/linux/if_link.h >> >+++ b/include/uapi/linux/if_link.h >> >@@ -486,6 +486,13 @@ enum macsec_validation_type { >> > MACSEC_VALIDATE_MAX = __MACSEC_VALIDATE_END - 1, >> > }; >> > >> >+enum macsec_offload { >> >+ MACSEC_OFFLOAD_OFF = 0, >> >+ MACSEC_OFFLOAD_PHY = 1, >> >> No need to assign 0, 1 here. That is given. > >Right, however MACSEC_VALIDATE_ uses the same notation. I think it's >nice to be consistent, but of course of patch can be sent to convert >both of those enums. Ok. > >> >+ __MACSEC_OFFLOAD_END, >> >+ MACSEC_OFFLOAD_MAX = __MACSEC_OFFLOAD_END - 1, >> >+}; >> >+ >> > /* IPVLAN section */ >> > enum { >> > IFLA_IPVLAN_UNSPEC, >> >diff --git a/tools/include/uapi/linux/if_link.h b/tools/include/uapi/linux/if_link.h >> >index 8aec8769d944..42efdb84d189 100644 >> >--- a/tools/include/uapi/linux/if_link.h >> >+++ b/tools/include/uapi/linux/if_link.h >> >> Why you are adding to this header? > >Because the two headers are synced. It is synced manually from time to time. (October is the last time) > >Thanks, >Antoine > >-- >Antoine Ténart, Bootlin >Embedded Linux and Kernel engineering >https://bootlin.com
Powered by blists - more mailing lists