netdev - Re: [PATCH nf] netfilter: arp_tables: init netns pointer in xt_tgdtor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200113175130.arh73uodxk4xvita@salvia>
Date:   Mon, 13 Jan 2020 18:51:30 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Florian Westphal <fw@...len.de>
Cc:     netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        syzkaller-bugs@...glegroups.com,
        syzbot+91bdd8eece0f6629ec8b@...kaller.appspotmail.com
Subject: Re: [PATCH nf] netfilter: arp_tables: init netns pointer in
 xt_tgdtor_param struct

On Sat, Jan 11, 2020 at 11:19:53PM +0100, Florian Westphal wrote:
> An earlier commit (1b789577f655060d98d20e,
> "netfilter: arp_tables: init netns pointer in xt_tgchk_param struct"
> fixed missing net initialization for arptables, but turns out it was
> incomplete.  We can get a very similar struct net NULL deref during
> error unwinding:
> 
> general protection fault: 0000 [#1] PREEMPT SMP KASAN
> RIP: 0010:xt_rateest_put+0xa1/0x440 net/netfilter/xt_RATEEST.c:77
>  xt_rateest_tg_destroy+0x72/0xa0 net/netfilter/xt_RATEEST.c:175
>  cleanup_entry net/ipv4/netfilter/arp_tables.c:509 [inline]
>  translate_table+0x11f4/0x1d80 net/ipv4/netfilter/arp_tables.c:587
>  do_replace net/ipv4/netfilter/arp_tables.c:981 [inline]
>  do_arpt_set_ctl+0x317/0x650 net/ipv4/netfilter/arp_tables.c:1461
> 
> Also init the netns pointer in xt_tgdtor_param struct.

Applied.