netdev - Re: [PATCH v2 14/17] octeontx2-pf: Add basic ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200114051726.298ca7ad@cakuba.hsd1.ca.comcast.net>
Date:   Tue, 14 Jan 2020 05:17:26 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Christina Jacob <cjacob@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH v2 14/17] octeontx2-pf: Add basic ethtool support

On Tue, 14 Jan 2020 12:32:17 +0530, sunil.kovvuri@...il.com wrote:
> +static const struct otx2_stat otx2_dev_stats[] = {
> +	OTX2_DEV_STAT(rx_bytes),
> +	OTX2_DEV_STAT(rx_frames),

> +	OTX2_DEV_STAT(rx_mcast_frames),
> +	OTX2_DEV_STAT(rx_drops),
> +
> +	OTX2_DEV_STAT(tx_bytes),
> +	OTX2_DEV_STAT(tx_frames),

> +	OTX2_DEV_STAT(tx_drops),

Why are these still here?

You are exposing the exact same stats via netlink:

+	stats->rx_bytes = dev_stats->rx_bytes;
+	stats->rx_packets = dev_stats->rx_frames;
+	stats->rx_dropped = dev_stats->rx_drops;
+	stats->multicast = dev_stats->rx_mcast_frames;
+
+	stats->tx_bytes = dev_stats->tx_bytes;
+	stats->tx_packets = dev_stats->tx_frames;
+	stats->tx_dropped = dev_stats->tx_drops;

We have been requiring that standard statistics are not duplicated in
ethtool since at least 2017. Example:

https://lore.kernel.org/netdev/20171006153059.193688a5@xeon-e3/

Please don't make me say this to you a third time :/

Also you have to provide a change long so reviewers know what changed
between v1 and v2. It's best to keep the changelog in the commit
messages (rather than hidden under ---) so the history is preserved.