netdev - Re: [PATCH] net: phy: dp83867: Set FORCE_LINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jan 2020 14:25:02 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com, hkallweit1@...il.com,
        kernel@...gutronix.de
Subject: Re: [PATCH] net: phy: dp83867: Set FORCE_LINK_GOOD do default after
 reset

Hi Michael

> @@ -635,6 +636,16 @@ static int dp83867_phy_reset(struct phy_device *phydev)
>  
>  	usleep_range(10, 20);
>  
> +	/* After reset FORCE_LINK_GOOD bit is set. Although the
> +	 * default value should be unset. Disable FORCE_LINK_GOOD
> +	 * for the phy to work properly.
> +	 */
> +	val = phy_read(phydev, MII_DP83867_PHYCTRL);
> +	if (val & DP83867_PHYCR_FORCE_LINK_GOOD) {
> +		val &= ~(DP83867_PHYCR_FORCE_LINK_GOOD);
> +		phy_write(phydev, MII_DP83867_PHYCTRL, val);
> +	}

You could use phy_modify().

    Andrew