lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jan 2020 05:45:43 -0800 From: Jakub Kicinski <kubakici@...pl> To: Martin Schiller <ms@....tdt.de> Cc: khc@...waw.pl, davem@...emloft.net, linux-x25@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] wan/hdlc_x25: make lapb params configurable On Tue, 14 Jan 2020 14:33:51 +0100, Martin Schiller wrote: > On 2020-01-14 13:51, Jakub Kicinski wrote: > > On Tue, 14 Jan 2020 06:37:03 +0100, Martin Schiller wrote: > >> >> diff --git a/include/uapi/linux/hdlc/ioctl.h > >> >> b/include/uapi/linux/hdlc/ioctl.h > >> >> index 0fe4238e8246..3656ce8b8af0 100644 > >> >> --- a/include/uapi/linux/hdlc/ioctl.h > >> >> +++ b/include/uapi/linux/hdlc/ioctl.h > >> >> @@ -3,7 +3,7 @@ > >> >> #define __HDLC_IOCTL_H__ > >> >> > >> >> > >> >> -#define GENERIC_HDLC_VERSION 4 /* For synchronization with sethdlc > >> >> utility */ > >> >> +#define GENERIC_HDLC_VERSION 5 /* For synchronization with sethdlc > >> >> utility */ > >> > > >> > What's the backward compatibility story in this code? > >> > >> Well, I thought I have to increment the version to keep the kernel > >> code > >> and the sethdlc utility in sync (like the comment says). > > > > Perhaps I chose the wrong place for asking this question, IOCTL code > > was my real worry. I don't think this version number is validated so > > I think bumping it shouldn't break anything? > > sethdlc validates the GENERIC_HDLC_VERSION at compile time. > > https://mirrors.edge.kernel.org/pub/linux/utils/net/hdlc/ Aw, okay, best not to bump it then. > Another question: > Where do I have to send my patch for sethdlc to? No idea :)
Powered by blists - more mailing lists