lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jan 2020 08:39:40 -0700 From: David Ahern <dsahern@...il.com> To: Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org Cc: davem@...emloft.net, kuba@...nel.org, jiri@...lanox.com, roopa@...ulusnetworks.com, mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com> Subject: Re: [PATCH net-next v2 02/10] ipv4: Encapsulate function arguments in a struct On 1/14/20 4:23 AM, Ido Schimmel wrote: > From: Ido Schimmel <idosch@...lanox.com> > > fib_dump_info() is used to prepare RTM_{NEW,DEL}ROUTE netlink messages > using the passed arguments. Currently, the function takes 11 arguments, > 6 of which are attributes of the route being dumped (e.g., prefix, TOS). > > The next patch will need the function to also dump to user space an > indication if the route is present in hardware or not. Instead of > passing yet another argument, change the function to take a struct > containing the different route attributes. > > v2: > * Name last argument of fib_dump_info() > * Move 'struct fib_rt_info' to include/net/ip_fib.h so that it could > later be passed to fib_alias_hw_flags_set() > > Signed-off-by: Ido Schimmel <idosch@...lanox.com> > --- > include/net/ip_fib.h | 9 +++++++++ > net/ipv4/fib_lookup.h | 5 ++--- > net/ipv4/fib_semantics.c | 26 ++++++++++++++++---------- > net/ipv4/fib_trie.c | 14 +++++++++----- > net/ipv4/route.c | 12 +++++++++--- > 5 files changed, 45 insertions(+), 21 deletions(-) > Reviewed-by: David Ahern <dsahern@...il.com>
Powered by blists - more mailing lists