lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jan 2020 17:09:23 +0100 From: Jose Abreu <Jose.Abreu@...opsys.com> To: netdev@...r.kernel.org Cc: Joao Pinto <Joao.Pinto@...opsys.com>, Jose Abreu <Jose.Abreu@...opsys.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <Jose.Abreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>, Maxime Coquelin <mcoquelin.stm32@...il.com>, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Alexey Brodkin <Alexey.Brodkin@...opsys.com>, Vineet Gupta <Vineet.Gupta1@...opsys.com>, linux-snps-arc@...ts.infradead.org Subject: [PATCH net 3/4] net: stmmac: selftests: Guard VLAN Perfect test against non supported HW When HW does not support perfect filtering the feature will not be enabled in the net_device. Add a check for this to prevent failures. Fixes: 1b2250a04c1f ("net: stmmac: selftests: Add tests for VLAN Perfect Filtering") Signed-off-by: Jose Abreu <Jose.Abreu@...opsys.com> --- Cc: Giuseppe Cavallaro <peppe.cavallaro@...com> Cc: Alexandre Torgue <alexandre.torgue@...com> Cc: Jose Abreu <joabreu@...opsys.com> Cc: "David S. Miller" <davem@...emloft.net> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com> Cc: netdev@...r.kernel.org Cc: linux-stm32@...md-mailman.stormreply.com Cc: linux-arm-kernel@...ts.infradead.org Cc: linux-kernel@...r.kernel.org Cc: Alexey Brodkin <abrodkin@...opsys.com> Cc: Vineet Gupta <vgupta@...opsys.com> Cc: linux-snps-arc@...ts.infradead.org --- drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c index 7edee3c87ac9..450d7dac3ea6 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c @@ -971,6 +971,9 @@ static int stmmac_test_vlanfilt_perfect(struct stmmac_priv *priv) { int ret, prev_cap = priv->dma_cap.vlhash; + if (!(priv->dev->features & NETIF_F_HW_VLAN_CTAG_FILTER)) + return -EOPNOTSUPP; + priv->dma_cap.vlhash = 0; ret = __stmmac_test_vlanfilt(priv); priv->dma_cap.vlhash = prev_cap; @@ -1063,6 +1066,9 @@ static int stmmac_test_dvlanfilt_perfect(struct stmmac_priv *priv) { int ret, prev_cap = priv->dma_cap.vlhash; + if (!(priv->dev->features & NETIF_F_HW_VLAN_STAG_FILTER)) + return -EOPNOTSUPP; + priv->dma_cap.vlhash = 0; ret = __stmmac_test_dvlanfilt(priv); priv->dma_cap.vlhash = prev_cap; -- 2.7.4
Powered by blists - more mailing lists