netdev - Re: [PATCH net-next v2 02/10] ipv4: Encapsulate function arguments in a struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200114163532.GM2131@nanopsycho>
Date:   Tue, 14 Jan 2020 17:35:32 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        jiri@...lanox.com, dsahern@...il.com, roopa@...ulusnetworks.com,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next v2 02/10] ipv4: Encapsulate function arguments
 in a struct

Tue, Jan 14, 2020 at 12:23:10PM CET, idosch@...sch.org wrote:
>From: Ido Schimmel <idosch@...lanox.com>
>
>fib_dump_info() is used to prepare RTM_{NEW,DEL}ROUTE netlink messages
>using the passed arguments. Currently, the function takes 11 arguments,
>6 of which are attributes of the route being dumped (e.g., prefix, TOS).
>
>The next patch will need the function to also dump to user space an
>indication if the route is present in hardware or not. Instead of
>passing yet another argument, change the function to take a struct
>containing the different route attributes.
>
>v2:
>* Name last argument of fib_dump_info()
>* Move 'struct fib_rt_info' to include/net/ip_fib.h so that it could
>  later be passed to fib_alias_hw_flags_set()
>
>Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Reviewed-by: Jiri Pirko <jiri@...lanox.com>