netdev - Re: [PATCH bpf-next] bpf: Fix seq_show for BPF_MAP_TYPE_STRUCT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Jan 2020 09:56:27 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Kernel Team <kernel-team@...com>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Fix seq_show for BPF_MAP_TYPE_STRUCT_OPS

On Mon, Jan 13, 2020 at 11:26 PM Martin KaFai Lau <kafai@...com> wrote:
>
> Instead of using bpf_struct_ops_map_lookup_elem() which is
> not implemented, bpf_struct_ops_map_seq_show_elem() should
> also use bpf_struct_ops_map_sys_lookup_elem() which does
> an inplace update to the value.  The change allocates
> a value to pass to bpf_struct_ops_map_sys_lookup_elem().
>
> [root@...h-fb-vm1 bpf]# cat /sys/fs/bpf/dctcp
> {{{1}},BPF_STRUCT_OPS_STATE_INUSE,{{00000000df93eebc,00000000df93eebc},0,2, ...
>
> Fixes: 85d33df357b6 ("bpf: Introduce BPF_MAP_TYPE_STRUCT_OPS")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Martin KaFai Lau <kafai@...com>

Applied. Thanks