lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jan 2020 11:05:40 -0800 (PST) From: David Miller <davem@...emloft.net> To: edumazet@...gle.com Cc: netdev@...r.kernel.org, eric.dumazet@...il.com, pfrenard@...il.com, stefan.wahren@...e.com, woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com Subject: Re: [PATCH net] net: usb: lan78xx: limit size of local TSO packets From: Eric Dumazet <edumazet@...gle.com> Date: Mon, 13 Jan 2020 09:27:11 -0800 > lan78xx_tx_bh() makes sure to not exceed MAX_SINGLE_PACKET_SIZE > bytes in the aggregated packets it builds, but does > nothing to prevent large GSO packets being submitted. > > Pierre-Francois reported various hangs when/if TSO is enabled. > > For localy generated packets, we can use netif_set_gso_max_size() > to limit the size of TSO packets. > > Note that forwarded packets could still hit the issue, > so a complete fix might require implementing .ndo_features_check > for this driver, forcing a software segmentation if the size > of the TSO packet exceeds MAX_SINGLE_PACKET_SIZE. > > Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > Reported-by: RENARD Pierre-Francois <pfrenard@...il.com> > Tested-by: RENARD Pierre-Francois <pfrenard@...il.com> Applied and queued up for -stable, thanks Eric.
Powered by blists - more mailing lists