lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jan 2020 20:37:04 +0100 From: Daniel Borkmann <daniel@...earbox.net> To: Li RongQing <lirongqing@...du.com>, netdev@...r.kernel.org, songliubraving@...com, bpf@...r.kernel.org Subject: Re: [PATCH][bpf-next][v2] bpf: return -EBADRQC for invalid map type in __bpf_tx_xdp_map On 1/10/20 2:04 AM, Li RongQing wrote: > a negative value should be returned if map->map_type > is invalid although that seems unlikely now, then the > caller will continue to handle buffer, otherwise the > buffer will be leaked > > Daniel Borkmann suggested: > -EBADRQC should be returned to keep consistent with > xdp_do_generic_redirect_map() for the tracepoint output > and not to be confused with -EOPNOTSUPP from other > locations like dev_map_enqueue() when ndo_xdp_xmit > is missing or such. > > Suggested-by: Daniel Borkmann <daniel@...earbox.net> > Signed-off-by: Li RongQing <lirongqing@...du.com> Applied, thanks (fixed up commit message a bit).
Powered by blists - more mailing lists