netdev - Re: [PATCH net-next] net/mlx5e: allow TSO on VXLAN over VLAN topologies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Jan 2020 20:33:50 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "dcaratti@...hat.com" <dcaratti@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5e: allow TSO on VXLAN over VLAN
 topologies

On Thu, 2020-01-09 at 10:52 -0800, David Miller wrote:
> From: Davide Caratti <dcaratti@...hat.com>
> Date: Thu,  9 Jan 2020 12:07:59 +0100
> 
> > since mlx5 hardware can segment correctly TSO packets on VXLAN over
> VLAN
> > topologies, CPU usage can improve significantly if we enable tunnel
> > offloads in dev->vlan_features, like it was done in the past with
> other
> > NIC drivers (e.g. mlx4, be2net and ixgbe).
> > 
> > Signed-off-by: Davide Caratti <dcaratti@...hat.com>
> 
> Saeed, I am assuming you will review and integrate this.
> 
> Thank you.

LGTM, applied to net-next-mlx5, will run some tests and provide
feedback if any issues will surface, while i don't expect any.

Will submit to net-next in one of my upcoming net-next pull requests.

Thanks,
Saeed.