lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 13 Jan 2020 20:26:16 -0800
From:   Richard Cochran <>
To:     Vladis Dronov <>
Cc:     Antti Laakso <>,,,,,,
Subject: Re: [PATCH] ptp: free ptp device pin descriptors properly

On Mon, Jan 13, 2020 at 02:00:09PM +0100, Vladis Dronov wrote:
> There is a bug in ptp_clock_unregister(), where ptp_cleanup_pin_groups()
> first frees ptp->pin_{,dev_}attr, but then posix_clock_unregister() needs
> them to destroy a related sysfs device.
> These functions can not be just swapped, as posix_clock_unregister() frees
> ptp which is needed in the ptp_cleanup_pin_groups(). Fix this by calling
> ptp_cleanup_pin_groups() in ptp_clock_release(), right before ptp is freed.
> This makes this patch fix an UAF bug in a patch which fixes an UAF bug.
> Reported-by: Antti Laakso <>
> Fixes: a33121e5487b ("ptp: fix the race between the release of ptp_clock and cdev")
> Link:
> Signed-off-by: Vladis Dronov <>

Acked-by: Richard Cochran <>

Powered by blists - more mailing lists