lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jan 2020 23:51:42 -0800 From: Prashant Malani <pmalani@...omium.org> To: Kai-Heng Feng <kai.heng.feng@...onical.com> Cc: David Miller <davem@...emloft.net>, Hayes Wang <hayeswang@...ltek.com>, Jakub Kicinski <jakub.kicinski@...ronome.com>, Grant Grundler <grundler@...omium.org>, Mario Limonciello <mario.limonciello@...l.com>, David Chen <david.chen7@...l.com>, "open list:USB NETWORKING DRIVERS" <linux-usb@...r.kernel.org>, "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] r8152: Add MAC passthrough support to new device On Mon, Jan 13, 2020 at 8:41 PM Kai-Heng Feng <kai.heng.feng@...onical.com> wrote: > > Device 0xa387 also supports MAC passthrough, therefore add it to the > whitelst. > > BugLink: https://bugs.launchpad.net/bugs/1827961/comments/30 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com> > --- > drivers/net/usb/r8152.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index c5ebf35d2488..42dcf1442cc0 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -6657,7 +6657,8 @@ static int rtl8152_probe(struct usb_interface *intf, > } > > if (le16_to_cpu(udev->descriptor.idVendor) == VENDOR_ID_LENOVO && > - le16_to_cpu(udev->descriptor.idProduct) == 0x3082) > + (le16_to_cpu(udev->descriptor.idProduct) == 0x3082 || > + le16_to_cpu(udev->descriptor.idProduct) == 0xa387)) Perhaps we can try to use #define's for these vendor IDs (like https://github.com/torvalds/linux/blob/master/drivers/net/usb/r8152.c#L680) ? > set_bit(LENOVO_MACPASSTHRU, &tp->flags); > > if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 && udev->serial && > -- > 2.17.1 >
Powered by blists - more mailing lists