lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jan 2020 01:46:30 +0000 From: Pkshih <pkshih@...ltek.com> To: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "colin.king@...onical.com" <colin.king@...onical.com>, "kvalo@...eaurora.org" <kvalo@...eaurora.org>, "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: Re: [PATCH] rtlwifi: rtl8188ee: remove redundant assignment to variable cond On Tue, 2020-01-14 at 16:56 +0000, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Variable cond is being assigned with a value that is never > read, it is assigned a new value later on. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@...onical.com> Acked-by: Ping-Ke Shih <pkshih@...ltek.com> Thank you!! > --- > drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c > b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c > index 5ca900f97d66..d13983ec09ad 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c > @@ -264,7 +264,7 @@ static bool _rtl88e_check_condition(struct ieee80211_hw > *hw, > u32 _board = rtlefuse->board_type; /*need efuse define*/ > u32 _interface = rtlhal->interface; > u32 _platform = 0x08;/*SupportPlatform */ > - u32 cond = condition; > + u32 cond; > > if (condition == 0xCDCDCDCD) > return true;
Powered by blists - more mailing lists