netdev - Re: [PATCH net-next] sfc: move MCDI filtering code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Jan 2020 04:40:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     amaftei@...arflare.com
Cc:     netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
        scrum-linux@...arflare.com
Subject: Re: [PATCH net-next] sfc: move MCDI filtering code

From: "Alex Maftei (amaftei)" <amaftei@...arflare.com>
Date: Tue, 14 Jan 2020 12:27:56 +0000

> Packet filter management is implemented by this code.
> Everything moved was also renamed.
> 
> Many style fixes included.
> 
> Signed-off-by: Alexandru-Mihai Maftei <amaftei@...arflare.com>

Several problesm with this:

1) Moving code and making style fixes are two separate changes.

2) The renames are a separate change as welll.

3) This patch gives warnings from git when applying:

Applying: sfc: move MCDI filtering code
.git/rebase-apply/patch:5071: space before tab in indent.
			 	  enum efx_filter_priority priority);
.git/rebase-apply/patch:5086: space before tab in indent.
				 	struct efx_rss_context *ctx,
warning: 2 lines add whitespace errors.