lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jan 2020 15:55:33 +0100 From: Guillaume Nault <gnault@...hat.com> To: Nicolas Dichtel <nicolas.dichtel@...nd.com> Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org Subject: Re: [PATCH net-next 1/2] netns: Parse NETNSA_FD and NETNSA_PID as signed integers On Wed, Jan 15, 2020 at 02:30:13PM +0100, Nicolas Dichtel wrote: > Le 14/01/2020 à 23:25, Guillaume Nault a écrit : > > These attributes represent signed values (file descriptors and PIDs). > > Make that clear in nla_policy. > > > > Signed-off-by: Guillaume Nault <gnault@...hat.com> > > --- > > net/core/net_namespace.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c > > index 6412c1fbfcb5..85c565571c1c 100644 > > --- a/net/core/net_namespace.c > > +++ b/net/core/net_namespace.c > > @@ -706,8 +706,8 @@ static struct pernet_operations __net_initdata net_ns_ops = { > > static const struct nla_policy rtnl_net_policy[NETNSA_MAX + 1] = { > > [NETNSA_NONE] = { .type = NLA_UNSPEC }, > > [NETNSA_NSID] = { .type = NLA_S32 }, > > - [NETNSA_PID] = { .type = NLA_U32 }, > > - [NETNSA_FD] = { .type = NLA_U32 }, > > + [NETNSA_PID] = { .type = NLA_S32 }, > > + [NETNSA_FD] = { .type = NLA_S32 }, > Please, keep them consistent with IFLA_NET_NS_*: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/core/rtnetlink.c?h=v5.5-rc6#n1793 > Oh right! I'll also update rtnetlink.c in v2. Thanks!
Powered by blists - more mailing lists