lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jan 2020 16:15:48 +0000 From: Jose Abreu <Jose.Abreu@...opsys.com> To: Ong Boon Leong <boon.leong.ong@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: Jakub Kicinski <kubakici@...pl>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, "David S . Miller" <davem@...emloft.net>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Tan Tee Min <tee.min.tan@...el.com>, "Voon Weifeng" <weifeng.voon@...el.com>, "linux-stm32@...md-mailman.stormreply.com" <linux-stm32@...md-mailman.stormreply.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH net v2 1/4] net: stmmac: Fix incorrect location to set real_num_rx|tx_queues From: Ong Boon Leong <boon.leong.ong@...el.com> Date: Jan/15/2020, 07:10:00 (UTC+00:00) > From: Aashish Verma <aashishx.verma@...el.com> > > netif_set_real_num_tx_queues() & netif_set_real_num_rx_queues() should be > used to inform network stack about the real Tx & Rx queue (active) number > in both stmmac_open() and stmmac_resume(), therefore, we move the code > from stmmac_dvr_probe() to stmmac_hw_setup(). > > Fixes: c02b7a914551 ("net: stmmac: use netif_set_real_num_{rx,tx}_queues") > Signed-off-by: Aashish Verma <aashishx.verma@...el.com> > Signed-off-by: Ong Boon Leong <boon.leong.ong@...el.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 80d59b775907..0780e00580a2 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -2624,6 +2624,10 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp) > if (priv->dma_cap.vlins) > stmmac_enable_vlan(priv, priv->hw, STMMAC_VLAN_INSERT); > > + /* Configure real RX and TX queues */ > + netif_set_real_num_rx_queues(dev, priv->plat->rx_queues_to_use); > + netif_set_real_num_tx_queues(dev, priv->plat->tx_queues_to_use); > + Nack. You need to hold rtnl lock when calling this and at suspend / resume you don't. --- Thanks, Jose Miguel Abreu
Powered by blists - more mailing lists