netdev - Re: [PATCH v3 net] net/sched: act_ife: initalize ife->metalist earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5961acad0fa4ee00e00ad3773f39c9cb44df6929.camel@redhat.com>
Date:   Wed, 15 Jan 2020 18:38:30 +0100
From:   Davide Caratti <dcaratti@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH v3 net] net/sched: act_ife: initalize ife->metalist
 earlier

On Wed, 2020-01-15 at 08:20 -0800, Eric Dumazet wrote:
> It seems better to init ife->metalist earlier in tcf_ife_init()
> to avoid the following crash :

hello Eric, LGTM now, thanks!

[...]

> Fixes: 11a94d7fd80f ("net/sched: act_ife: validate the control action inside init()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Cc: Davide Caratti <dcaratti@...hat.com>
> ---
> v2,v3: addressed Davide feedbacks.

Reviewed-by: Davide Caratti <dcaratti@...hat.com>