netdev - Re: [PATCH bpf-next] xsk: support allocations of large umems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F5A36D1D-633C-4CDB-A49D-71DE73E26963@gmail.com>
Date:   Wed, 15 Jan 2020 11:10:35 -0800
From:   "Jonathan Lemon" <jonathan.lemon@...il.com>
To:     "Magnus Karlsson" <magnus.karlsson@...el.com>
Cc:     bjorn.topel@...el.com, ast@...nel.org, daniel@...earbox.net,
        netdev@...r.kernel.org, rgoodfel@....edu, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next] xsk: support allocations of large umems



On 14 Jan 2020, at 1:49, Magnus Karlsson wrote:

> When registering a umem area that is sufficiently large (>1G on an
> x86), kmalloc cannot be used to allocate one of the internal data
> structures, as the size requested gets too large. Use kvmalloc instead
> that falls back on vmalloc if the allocation is too large for kmalloc.
>
> Also add accounting for this structure as it is triggered by a user
> space action (the XDP_UMEM_REG setsockopt) and it is by far the
> largest structure of kernel allocated memory in xsk.
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> Reported-by: Ryan Goodfellow <rgoodfel@....edu>

Acked-by: Jonathan Lemon <jonathan.lemon@...il.com>