lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jan 2020 13:43:39 -0800 (PST) From: David Miller <davem@...emloft.net> To: ms@....tdt.de Cc: kubakici@...pl, khc@...waw.pl, linux-x25@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 1/2] wan/hdlc_x25: make lapb params configurable From: Martin Schiller <ms@....tdt.de> Date: Tue, 14 Jan 2020 15:02:22 +0100 > This enables you to configure mode (DTE/DCE), Modulo, Window, T1, T2, N2 via > sethdlc (which needs to be patched as well). > > Signed-off-by: Martin Schiller <ms@....tdt.de> I don't know how wise it is to add new ioctls to this old driver. Also, none of these ioctls even have COMPAT handling so they will never work from a 32-bit binary running on a 64-bit kernel for example. Also: > +static struct x25_state* state(hdlc_device *hdlc) It is always "type *func" never "type* func" > static int x25_open(struct net_device *dev) > { > int result; > + hdlc_device *hdlc = dev_to_hdlc(dev); > + struct lapb_parms_struct params; > static const struct lapb_register_struct cb = { Please make this reverse christmas tree ordered. > @@ -186,6 +217,9 @@ static struct hdlc_proto proto = { > > static int x25_ioctl(struct net_device *dev, struct ifreq *ifr) > { > + x25_hdlc_proto __user *x25_s = ifr->ifr_settings.ifs_ifsu.x25; > + const size_t size = sizeof(x25_hdlc_proto); > + x25_hdlc_proto new_settings; > hdlc_device *hdlc = dev_to_hdlc(dev); > int result; Likewise.
Powered by blists - more mailing lists