lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jan 2020 23:11:21 +0100 From: Toke Høiland-Jørgensen <toke@...hat.com> To: Jesper Dangaard Brouer <brouer@...hat.com> Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net>, Alexei Starovoitov <ast@...nel.org>, David Miller <davem@...emloft.net>, Björn Töpel <bjorn.topel@...il.com>, John Fastabend <john.fastabend@...il.com>, brouer@...hat.com Subject: Re: [PATCH bpf-next v2 1/2] xdp: Move devmap bulk queue into struct net_device Jesper Dangaard Brouer <brouer@...hat.com> writes: > On Mon, 13 Jan 2020 19:10:55 +0100 > Toke Høiland-Jørgensen <toke@...hat.com> wrote: > >> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c >> index da9c832fc5c8..030d125c3839 100644 >> --- a/kernel/bpf/devmap.c >> +++ b/kernel/bpf/devmap.c > [...] >> @@ -346,8 +340,7 @@ static int bq_xmit_all(struct xdp_bulk_queue *bq, u32 flags) >> out: >> bq->count = 0; >> >> - trace_xdp_devmap_xmit(&obj->dtab->map, obj->idx, >> - sent, drops, bq->dev_rx, dev, err); >> + trace_xdp_devmap_xmit(NULL, 0, sent, drops, bq->dev_rx, dev, err); > > Hmm ... I don't like that we lose the map_id and map_index identifier. > This is part of our troubleshooting interface. Hmm, I guess I can take another look at whether there's a way to avoid that. Any ideas? -Toke
Powered by blists - more mailing lists