netdev - Re: [PATCH v2 bpf-next 5/5] bpftool: Support dumping a map with btf_vmlinux_value_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200115224955.45evt277ino4j5zi@kafai-mbp.dhcp.thefacebook.com>
Date:   Wed, 15 Jan 2020 22:49:59 +0000
From:   Martin Lau <kafai@...com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
CC:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        "Kernel Team" <Kernel-team@...com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 bpf-next 5/5] bpftool: Support dumping a map with
 btf_vmlinux_value_type_id

On Wed, Jan 15, 2020 at 02:46:10PM -0800, Andrii Nakryiko wrote:
> On Wed, Jan 15, 2020 at 2:28 PM Martin KaFai Lau <kafai@...com> wrote:
> >
> > This patch makes bpftool support dumping a map's value properly
> > when the map's value type is a type of the running kernel's btf.
> > (i.e. map_info.btf_vmlinux_value_type_id is set instead of
> > map_info.btf_value_type_id).  The first usecase is for the
> > BPF_MAP_TYPE_STRUCT_OPS.
> >
> > Signed-off-by: Martin KaFai Lau <kafai@...com>
> > ---
> 
> LGTM.
> 
> Acked-by: Andrii Nakryiko <andriin@...com>
Thanks for the review!

I just noticied I forgot to remove the #include "libbpf_internal.h".
I will respin one more.