netdev - Re: [PATCH v2 bpf-next 5/5] bpftool: Support dumping a map with btf_vmlinux_value_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzZDOjnZVjTob-KUOZ_J9YHnbwC6Lzj3vPA9aB95kx7zRA@mail.gmail.com>
Date:   Wed, 15 Jan 2020 15:41:42 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Martin Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Kernel Team <Kernel-team@...com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 bpf-next 5/5] bpftool: Support dumping a map with btf_vmlinux_value_type_id

On Wed, Jan 15, 2020 at 3:12 PM Martin Lau <kafai@...com> wrote:
>
> On Wed, Jan 15, 2020 at 02:59:59PM -0800, Andrii Nakryiko wrote:
> > On Wed, Jan 15, 2020 at 2:50 PM Martin Lau <kafai@...com> wrote:
> > >
> > > On Wed, Jan 15, 2020 at 02:46:10PM -0800, Andrii Nakryiko wrote:
> > > > On Wed, Jan 15, 2020 at 2:28 PM Martin KaFai Lau <kafai@...com> wrote:
> > > > >
> > > > > This patch makes bpftool support dumping a map's value properly
> > > > > when the map's value type is a type of the running kernel's btf.
> > > > > (i.e. map_info.btf_vmlinux_value_type_id is set instead of
> > > > > map_info.btf_value_type_id).  The first usecase is for the
> > > > > BPF_MAP_TYPE_STRUCT_OPS.
> > > > >
> > > > > Signed-off-by: Martin KaFai Lau <kafai@...com>
> > > > > ---
> > > >
> > > > LGTM.
> > > >
> > > > Acked-by: Andrii Nakryiko <andriin@...com>
> > > Thanks for the review!
> > >
> > > I just noticied I forgot to remove the #include "libbpf_internal.h".
> > > I will respin one more.
> >
> > didn't notice that. Please also update a subject on patch exposing
> > libbpf_find_kernel_btf (it still mentions old name).
> oops. already went out. :p
> The commit message mentioned the renaming from old to new name.

no worries