netdev - Re: [PATCH] xfrm: support output_mark for offload ESP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200115095358.GQ8621@gauss3.secunet.de>
Date:   Wed, 15 Jan 2020 10:53:58 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Ulrich Weber <ulrich.weber@...il.com>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH] xfrm: support output_mark for offload ESP packets

On Tue, Jan 14, 2020 at 02:29:54PM +0100, Ulrich Weber wrote:
> Commit 9b42c1f179a6 ("xfrm: Extend the output_mark") added output_mark
> support but missed ESP offload support.
> 
> xfrm_smark_get() is not called within xfrm_input() for packets coming
> from esp4_gro_receive() or esp6_gro_receive(). Therefore call
> xfrm_smark_get() directly within these functions.
> 
> Signed-off-by: Ulrich Weber <ulrich.weber@...il.com>

Can you please add a 'Fixes' tag, so that it can be properly backported
to the -stable trees.

Thanks!