netdev - Re: [PATCH] net: ip6_gre: fix moving ip6gre between namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6465a655-2319-c6e6-d3ca-3cf5ba27640f@nokia.com>
Date:   Thu, 16 Jan 2020 16:43:28 +0200
From:   kortstro <niko.kortstrom@...ia.com>
To:     nicolas.dichtel@...nd.com, davem@...emloft.net,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: ip6_gre: fix moving ip6gre between namespaces

On 1/16/20 4:02 PM, Nicolas Dichtel wrote:
> Le 16/01/2020 à 10:43, Niko Kortstrom a écrit :
>> Support for moving IPv4 GRE tunnels between namespaces was added in
>> commit b57708add314 ("gre: add x-netns support"). The respective change
>> for IPv6 tunnels, commit 22f08069e8b4 ("ip6gre: add x-netns support")
>> did not drop NETIF_F_NETNS_LOCAL flag so moving them from one netns to
>> another is still denied in IPv6 case. Drop NETIF_F_NETNS_LOCAL flag from
>> ip6gre tunnels to allow moving ip6gre tunnel endpoints between network
>> namespaces.
>>
>> Signed-off-by: Niko Kortstrom <niko.kortstrom@...ia.com>
> LGTM.
> Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>
> Did you test real x-vrf cases with the three kinds of gre interfaces
> (gre/collect_md, gretap and erspan)?
This was only verified in real use with ip6gretap.