netdev - Re: [PATCH] net: nfc: Removing unnecessaey code in nci_open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200116.011708.119845983010961103.davem@davemloft.net>
Date:   Thu, 16 Jan 2020 01:17:08 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     blackgod016574@...il.com
Cc:     tglx@...utronix.de, alexios.zavras@...el.com, allison@...utok.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: nfc: Removing unnecessaey code in
 nci_open_device()

From: Gen Zhang <blackgod016574@...il.com>
Date: Thu, 16 Jan 2020 10:52:04 +0800

> In nci_open_device(), since we already call clear_bit(), so set ndev->flags
> to 0 is not needed.
> 
> Signed-off-by: Gen Zhang <blackgod016574@...il.com>

There are several bits in this flags value, not just the one managed
here in this function (NCI_INIT).

This assignment is harmless and makes the code easier to audit,
therefore I am not applying this patch.