netdev - Re: [PATCH net] net: dsa: sja1105: Don't error out on disabled ports with no phy-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16c5ec6f-fae7-6a51-1814-dbd939c32ac0@gmail.com>
Date:   Thu, 16 Jan 2020 10:38:04 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org, linux@...linux.org.uk
Cc:     andrew@...n.ch, vivien.didelot@...il.com,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net] net: dsa: sja1105: Don't error out on disabled ports
 with no phy-mode

On 1/16/20 10:36 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> The sja1105_parse_ports_node function was tested only on device trees
> where all ports were enabled. Fix this check so that the driver
> continues to probe only with the ports where status is not "disabled",
> as expected.
> 
> Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>  drivers/net/dsa/sja1105/sja1105_main.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
> index 784e6b8166a0..b27ef01b9445 100644
> --- a/drivers/net/dsa/sja1105/sja1105_main.c
> +++ b/drivers/net/dsa/sja1105/sja1105_main.c
> @@ -580,6 +580,9 @@ static int sja1105_parse_ports_node(struct sja1105_private *priv,
>  		u32 index;
>  		int err;
>  
> +		if (!of_device_is_available(child))
> +			continue;

This works, or you can use for_each_available_child_of_node()?

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian