lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 16 Jan 2020 04:27:22 -0800 (PST)
From:   David Miller <>
Subject: Re: [PATCH] net: optimize cmpxchg in ip_idents_reserve

From: Shaokun Zhang <>
Date: Wed, 15 Jan 2020 11:23:40 +0800

> From: Yuqi Jin <>
> atomic_try_cmpxchg is called instead of atomic_cmpxchg that can reduce
> the access number of the global variable @p_id in the loop. Let's
> optimize it for performance.
> Cc: "David S. Miller" <>
> Cc: Alexey Kuznetsov <>
> Cc: Hideaki YOSHIFUJI <>
> Cc: Eric Dumazet <>
> Cc: Yang Guo <>
> Signed-off-by: Yuqi Jin <>
> Signed-off-by: Shaokun Zhang <>

I doubt this makes any measurable improvement in performance.

If you can document a specific measurable improvement under
a useful set of circumstances for real usage, then put those
details into the commit message and resubmit.

Otherwise, I'm not applying this, sorry.

Powered by blists - more mailing lists