netdev - Re: [PATCH net] net: dsa: tag_qca: fix doubled Tx statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200116.050029.2278636258736479115.davem@davemloft.net>
Date:   Thu, 16 Jan 2020 05:00:29 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     alobakin@...nk.ru
Cc:     andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
        john@...ozen.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: tag_qca: fix doubled Tx statistics

From: Alexander Lobakin <alobakin@...nk.ru>
Date: Wed, 15 Jan 2020 11:56:52 +0300

> DSA subsystem takes care of netdev statistics since commit 4ed70ce9f01c
> ("net: dsa: Refactor transmit path to eliminate duplication"), so
> any accounting inside tagger callbacks is redundant and can lead to
> messing up the stats.
> This bug is present in Qualcomm tagger since day 0.
> 
> Fixes: cafdc45c949b ("net-next: dsa: add Qualcomm tag RX/TX handler")
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Alexander Lobakin <alobakin@...nk.ru>

Applied and queued up for -stable.