netdev - RE: [PATCH] net: stmmac: platform: use generic device api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR12MB27279A52D52B5DAB84F47BE3DC310@BYAPR12MB2727.namprd12.prod.outlook.com>
Date:   Fri, 17 Jan 2020 18:28:21 +0000
From:   Ajay Gupta <ajayg@...dia.com>
To:     Chen-Yu Tsai <wens@...nel.org>, Ajay Gupta <ajaykuee@...il.com>
CC:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Thierry Reding <treding@...dia.com>,
        "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>
Subject: RE: [PATCH] net: stmmac: platform: use generic device api

Hi ChenYu

> -----Original Message-----
> From: Chen-Yu Tsai <wens@...nel.org>
> Sent: Thursday, January 16, 2020 7:34 PM
> To: Ajay Gupta <ajaykuee@...il.com>
> Cc: David Miller <davem@...emloft.net>; netdev <netdev@...r.kernel.org>;
> Thierry Reding <treding@...dia.com>; Ajay Gupta <ajayg@...dia.com>
> Subject: Re: [PATCH] net: stmmac: platform: use generic device api
> 
> External email: Use caution opening links or attachments
> 
> 
> Hi,
> 
> On Fri, Jan 17, 2020 at 2:21 AM Ajay Gupta <ajaykuee@...il.com> wrote:
> >
> > From: Ajay Gupta <ajayg@...dia.com>
> >
> > Use generic device api to allow reading more configuration parameter
> > from both DT or ACPI based devices.
> >
> > Signed-off-by: Ajay Gupta <ajayg@...dia.com>
> > ---
> > ACPI support related changes for dwc were reently queued [1] This
> > patch is required to read more configuration parameter through ACPI
> > table.
> >
> > [1] https://marc.info/?l=linux-netdev&m=157661974305024&w=2
> >
> >  .../ethernet/stmicro/stmmac/stmmac_platform.c | 49
> > +++++++++++--------
> 
> Even after your changes, there's still a lot of DT specific code in there, such as
> the MDIO device node parsing. Plus the whole thing is wrapped in "#ifdef
> CONFIG_OF".
> 
> Maybe it would make more sense to split out the generic device API parts into
> a separate function?
I am testing ACPI based device for dwmac-dwc-qos-eth controller. Also found
that " phy_node " structure used across other controllers (dwmac-rk, dwmac-sun8i)
plat->phy_node = of_parse_phandle(np, "phy-handle", 0);

It will require changes in other drivers  and testing them. I don't have hardware
for other controllers. 
I am trying to add minimal change what can be tested in context of dwmac-dwc-qos-eth.

Thanks
Ajay
>nvpublic
> 
> Regards
> ChenYu