netdev - Re: [PATCH 3/3] selftests/bpf: Build urandom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbKMJOGGv19jCakZusQ-R5pstPo0bSpns5k-mFm9b0W_Q@mail.gmail.com>
Date:   Fri, 17 Jan 2020 11:04:03 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Daniel Díaz <daniel.diaz@...aro.org>
Cc:     Shuah Khan <shuah@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        "open list:BPF (Safe dynamic programs and tools)" 
        <netdev@...r.kernel.org>,
        "open list:BPF (Safe dynamic programs and tools)" 
        <bpf@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] selftests/bpf: Build urandom_read with LDFLAGS and LDLIBS

On Fri, Jan 17, 2020 at 8:55 AM Daniel Díaz <daniel.diaz@...aro.org> wrote:
>
> During cross-compilation, it was discovered that LDFLAGS and
> LDLIBS were not being used while building binaries, leading
> to defaults which were not necessarily correct.
>
> OpenEmbedded reported this kind of problem:
>   ERROR: QA Issue: No GNU_HASH in the ELF binary [...], didn't pass LDFLAGS?
>
> Signed-off-by: Daniel Díaz <daniel.diaz@...aro.org>
> ---

Acked-by: Andrii Nakryiko <andriin@...com>

>  tools/testing/selftests/bpf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index e2fd6f8d579c..f1740113d5dc 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -88,7 +88,7 @@ $(notdir $(TEST_GEN_PROGS)                                            \
>          $(TEST_CUSTOM_PROGS)): %: $(OUTPUT)/% ;
>
>  $(OUTPUT)/urandom_read: urandom_read.c
> -       $(CC) -o $@ $< -Wl,--build-id
> +       $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) -Wl,--build-id
>
>  $(OUTPUT)/test_stub.o: test_stub.c
>         $(CC) -c $(CFLAGS) -o $@ $<
> --
> 2.20.1
>