netdev - Re: [PATCH v3 14/17] octeontx2-pf: Add basic ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200116173322.47271aad@cakuba.hsd1.ca.comcast.net>
Date:   Thu, 16 Jan 2020 17:33:22 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mkubecek@...e.cz,
        Christina Jacob <cjacob@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH v3 14/17] octeontx2-pf: Add basic ethtool support

On Fri, 17 Jan 2020 01:17:30 +0530, sunil.kovvuri@...il.com wrote:
> +#define DRV_NAME	"octeontx2-nicpf"
> +#define DRV_VERSION	"1.0"

> +	strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
> +	strlcpy(info->version, DRV_VERSION, sizeof(info->version));

We generally discourage the user of DRV_VERSION these days and suggest
to return the kernel version here. With backports and heavily patched
distro kernels this number quickly becomes counter-informative.

Thanks for the changes to the stats!