netdev - Re: [PATCH] net: stmmac: platform: use generic device api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v64hEN5=2FdxzMLfZm7RT68-+YZ70-_3fCPUyZ47C-9m1g@mail.gmail.com>
Date:   Fri, 17 Jan 2020 11:33:30 +0800
From:   Chen-Yu Tsai <wens@...nel.org>
To:     Ajay Gupta <ajaykuee@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Thierry Reding <treding@...dia.com>,
        Ajay Gupta <ajayg@...dia.com>
Subject: Re: [PATCH] net: stmmac: platform: use generic device api

Hi,

On Fri, Jan 17, 2020 at 2:21 AM Ajay Gupta <ajaykuee@...il.com> wrote:
>
> From: Ajay Gupta <ajayg@...dia.com>
>
> Use generic device api to allow reading more configuration
> parameter from both DT or ACPI based devices.
>
> Signed-off-by: Ajay Gupta <ajayg@...dia.com>
> ---
> ACPI support related changes for dwc were reently queued [1]
> This patch is required to read more configuration parameter
> through ACPI table.
>
> [1] https://marc.info/?l=linux-netdev&m=157661974305024&w=2
>
>  .../ethernet/stmicro/stmmac/stmmac_platform.c | 49 +++++++++++--------

Even after your changes, there's still a lot of DT specific code in
there, such as the MDIO device node parsing. Plus the whole thing
is wrapped in "#ifdef CONFIG_OF".

Maybe it would make more sense to split out the generic device API
parts into a separate function?

Regards
ChenYu