netdev - Re: [PATCH bpf-next] libbpf: revert bpf_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jan 2020 20:02:53 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] libbpf: revert bpf_helper_defs.h inclusion regression

On Thu, Jan 16, 2020 at 7:52 PM Andrii Nakryiko <andriin@...com> wrote:
>
> Revert bpf_helpers.h's change to include auto-generated bpf_helper_defs.h
> through <> instead of "", which causes it to be searched in include path. This
> can break existing applications that don't have their include path pointing
> directly to where libbpf installs its headers.
>
> There is ongoing work to make all (not just bpf_helper_defs.h) includes more
> consistent across libbpf and its consumers, but this unbreaks user code as is
> right now without any regressions. Selftests still behave sub-optimally
> (taking bpf_helper_defs.h from libbpf's source directory, if it's present
> there), which will be fixed in subsequent patches.
>
> Fixes: 6910d7d3867a ("selftests/bpf: Ensure bpf_helper_defs.h are taken from selftests dir")
> Reported-by: Toke Høiland-Jørgensen <toke@...hat.com>
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Applied. Thanks