lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 16 Jan 2020 20:43:55 -0800
From:   Cong Wang <>
To:     "Gustavo A. R. Silva" <>
Cc:     Jamal Hadi Salim <>, Jiri Pirko <>,
        "David S. Miller" <>,
        Linux Kernel Network Developers <>,
        LKML <>
Subject: Re: [PATCH net-next] net: sched: cls_u32: Use flexible-array member

On Thu, Jan 16, 2020 at 1:36 PM Gustavo A. R. Silva
<> wrote:
> Old code in the kernel uses 1-byte and 0-byte arrays to indicate the
> presence of a "variable length array":
> struct something {
>     int length;
>     u8 data[1];
> };
> struct something *instance;
> instance = kmalloc(sizeof(*instance) + size, GFP_KERNEL);
> instance->length = size;
> memcpy(instance->data, source, size);

Hmm, your patch is not correct, for u32 it is length+1, so you have
to allocate size+1 after you switch to zero-length array.

Take a look at u32_walk() if you have any doubt.


Powered by blists - more mailing lists