netdev - Re: [PATCH net] net: hns: fix soft lockup when there is not enough memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200117.022030.458227945074641961.davem@davemloft.net>
Date:   Fri, 17 Jan 2020 02:20:30 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     liuyonglong@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, salil.mehta@...wei.com,
        jakub.kicinski@...ronome.com
Subject: Re: [PATCH net] net: hns: fix soft lockup when there is not enough
 memory

From: Yonglong Liu <liuyonglong@...wei.com>
Date: Thu, 16 Jan 2020 15:41:17 +0800

> When there is not enough memory and napi_alloc_skb() return NULL,
> the HNS driver will print error message, and than try again, if
> the memory is not enough for a while, huge error message and the
> retry operation will cause soft lockup.
> 
> When napi_alloc_skb() return NULL because of no memory, we can
> get a warn_alloc() call trace, so this patch deletes the error
> message. We already use polling mode to handle irq, but the
> retry operation will render the polling weight inactive, this
> patch just return budget when the rx is not completed to avoid
> dead loop.
> 
> Fixes: 36eedfde1a36 ("net: hns: Optimize hns_nic_common_poll for better performance")
> Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support")
> Signed-off-by: Yonglong Liu <liuyonglong@...wei.com>

Applied and queued up for -stable.