netdev - Re: [PATCH v2 net-next] net: dsa: felix: Don't error out on disabled ports with no phy-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200117.042353.544899187026083387.davem@davemloft.net>
Date:   Fri, 17 Jan 2020 04:23:53 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     netdev@...r.kernel.org, linux@...linux.org.uk, andrew@...n.ch,
        f.fainelli@...il.com, vivien.didelot@...il.com,
        claudiu.manoil@....com, alexandru.marginean@....com,
        vladimir.oltean@....com
Subject: Re: [PATCH v2 net-next] net: dsa: felix: Don't error out on
 disabled ports with no phy-mode

From: Vladimir Oltean <olteanv@...il.com>
Date: Thu, 16 Jan 2020 20:41:53 +0200

> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> The felix_parse_ports_node function was tested only on device trees
> where all ports were enabled. Fix this check so that the driver
> continues to probe only with the ports where status is not "disabled",
> as expected.
> 
> Fixes: bdeced75b13f ("net: dsa: felix: Add PCS operations for PHYLINK")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
> Changes in v2:
> - Use for_each_available_child_of_node instead of open-coding the
>   of_device_is_available check.

Applied.