netdev - Re: [PATCH net-next 0/2] net: phy: add generic ndo_do_ioctl handler phy_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200119161240.GA17720@lunn.ch>
Date:   Sun, 19 Jan 2020 17:12:40 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: add generic ndo_do_ioctl handler
 phy_do_ioctl

On Sun, Jan 19, 2020 at 02:31:06PM +0100, Heiner Kallweit wrote:
> A number of network drivers has the same glue code to use phy_mii_ioctl
> as ndo_do_ioctl handler. So let's add such a generic ndo_do_ioctl
> handler to phylib. As first user convert r8169.

Hi Heiner

Looks sensible. 

Two questions:

Did you look at how many drivers don't make the running check? I know
there are some MAC drivers which allow PHY ioctls when the interface
is down.  So maybe we want to put _running_ into this helper name, and
add anther helper which does not check for running?

Do you plan to convert any more MAC drivers?

   Andrew