netdev - Re: [PATCH net] net: systemport: Fixed queue mapping in internal ring map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51eac93a-15b7-2645-64ad-943d872dfe7c@gmail.com>
Date:   Sun, 19 Jan 2020 09:48:27 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: systemport: Fixed queue mapping in internal ring
 map



On 1/17/2020 4:32 AM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Thu, 16 Jan 2020 13:08:58 -0800
> 
>> We would not be transmitting using the correct SYSTEMPORT transmit queue
>> during ndo_select_queue() which looks up the internal TX ring map
>> because while establishing the mapping we would be off by 4, so for
>> instance, when we populate switch port mappings we would be doing:
>>
>> switch port 0, queue 0 -> ring index #0
>> switch port 0, queue 1 -> ring index #1
>> ...
>> switch port 0, queue 3 -> ring index #3
>> switch port 1, queue 0 -> ring index #8 (4 + 4 * 1)
>> ...
>>
>> instead of using ring index #4. This would cause our ndo_select_queue()
>> to use the fallback queue mechanism which would pick up an incorrect
>> ring for that switch port. Fix this by using the correct switch queue
>> number instead of SYSTEMPORT queue number.
>>
>> Fixes: 3ed67ca243b3 ("net: systemport: Simplify queue mapping logic")
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Applied, but I had to fix the SHA1-ID of the Fixes tag to be:
> 
>     Fixes: 25c440704661 ("net: systemport: Simplify queue mapping logic")

Just like the other patch what happened is that the check_fixes script
from Stephen was able to resolve this incorrect SHA1 because I have both
the Broadcom STB downstream remote configured as well as upstream and
the script was not yet updated to make sure this was an object that can
be reached in the upstream remotes (yours, Linus...). This should be
corrected now, sorry about that.
-- 
Florian