netdev - Re: [PATCH net-next 0/2] net: phy: add generic ndo_do_ioctl handler phy_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200119185035.GC17720@lunn.ch>
Date:   Sun, 19 Jan 2020 19:50:35 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: add generic ndo_do_ioctl handler
 phy_do_ioctl

> Also it seems we don't consider situations like runtime PM yet.
> Then the MDIO bus may not be accessible, but ndev is running
> and PHY is attached.

I don't think this can happen. If the device is running, the MDIO bus
has to work, or phylib is broken.

I have had issue with the FEC, runtime PM and MDIO, but that was when
the interface was not running, but an Ethernet switch was using the
MDIO bus. MDIO transactions would time out, until i made the MDIO
operations PM aware.

But in general, we should keep the running test, just to avoid
breakage of assumptions we don't know about.

	 Andrew